Thread (3 messages) 3 messages, 2 authors, 2013-01-16
DORMANTno replies

[PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

From: Sangsu Park <hidden>
Date: 2013-01-16 01:08:06
Also in: linux-samsung-soc

On 1/15/2013 12:32 PM, Tushar Behera wrote: 
On 09/28/2012 04:09 PM, Sangsu Park wrote:
quoted
Remove I2S0 clock from peril since peril doesn't have I2S0 clock for
EXYNOS4.
quoted
Audio Subsystem block has I2S0 clk.

Signed-off-by: sangsu <sangsu@sangsu-P560.(none)>
---
 arch/arm/mach-exynos/clock-exynos4.c |    5 -----
 1 file changed, 5 deletions(-)
diff --git a/arch/arm/mach-exynos/clock-exynos4.c
b/arch/arm/mach-exynos/clock-exynos4.c
index 6a45c9a..fa8a134 100644
--- a/arch/arm/mach-exynos/clock-exynos4.c
+++ b/arch/arm/mach-exynos/clock-exynos4.c
@@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
 		.ctrlbit	= (1 << 18),
 	}, {
 		.name		= "iis",
-		.devname	= "samsung-i2s.0",
-		.enable		= exynos4_clk_ip_peril_ctrl,
-		.ctrlbit	= (1 << 19),
-	}, {
-		.name		= "iis",
 		.devname	= "samsung-i2s.1",
 		.enable		= exynos4_clk_ip_peril_ctrl,
 		.ctrlbit	= (1 << 20),
After this clock has been removed, I2S0 registration fails on EXYNOS4
based boards (clk_get for iis clock fails). The alternate clock from
Audio subsystem block is missing.
Yes, you're right.
I2S0 clock doesn't belong to peril clock.
Audio Subsystem has its own clock and also I2S0 clock.
That work might be missed. I'll do that work soon.

Thanks.
--
Tushar Behera
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help