Thread (1 message) 1 message, 1 author, 2013-01-14
DORMANTno replies

[PATCH] mmc: sdhci: query card presence from cd-gpio before asking SDHCI

From: Chris Ball <hidden>
Date: 2013-01-14 19:05:14
Also in: linux-mmc

Hi Shawn,

On Tue, Dec 11 2012, Shawn Guo wrote:
Call mmc_gpio_get_cd() to query card presence from cd-gpio before
asking SDHCI.  The rationale behind this change is that flag
SDHCI_QUIRK_BROKEN_CARD_DETECTION is designed for SDHCI controller to
tell that SDHCI_PRESENT_STATE is broken, and it should be used for this
case only.  So when cd-gpio is being used, the controller should set
the flag to tell that SDHCI_PRESENT_STATE is not available.

However, the existing code will skip checking cd-gpio as long as flag
SDHCI_QUIRK_BROKEN_CARD_DETECTION is set.  Change the querying order
between cd-gpio and SDHCI to support the rationale above.

Signed-off-by: Shawn Guo <redacted>
Thanks, pushed to mmc-next for 3.9.

- Chris.
-- 
Chris Ball   [off-list ref]   <http://printf.net/>
One Laptop Per Child
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help