On 04/01/13 00:26, Josh Coombs wrote:

I did a test build with the __init tag removed (which is not the
correct answer) and everything works.  GPIO is functional (I didn't
catch the power LED wasn't working prior), I don't get a panic, and I
can now reboot cleanly as well.  So that confirms the basic diagnosis.

I've been trying to wrap my head around include/linux/init.h to see
what the correct tagging should be but I'll admit, I'm in over my head
so far.  If anyone has suggested reading on the topic I'd be very
appreciative.

Hi Josh

The question is, when can this function be used? Only during boot time? 
Or at any time? For functions which are only used during boot, __init is 
O.K. However, since modules can also want to use clks, we need to be 
able to look up clocks at any time. So this function needs to be around 
all the time, which is the default behavior of no tag.

	Andrew