[PATCH v4 13/19] ARM: remove mach .handle_irq for VIC users
From: arnd@arndb.de (Arnd Bergmann)
Date: 2013-01-03 21:48:39
On Thursday 03 January 2013, Rob Herring wrote:
From: Rob Herring <redacted> Now that the VIC initialization sets up the handle_arch_irq pointer, we can remove it for all machines and make it static. Signed-off-by: Rob Herring <redacted> Cc: Ryan Mallon <redacted> Cc: Russell King <redacted> Cc: Hubert Feurstein <redacted> Cc: Alessandro Rubini <redacted> Cc: STEricsson <redacted> Cc: Ben Dooks <ben-linux@fluff.org> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Shiraz Hashim <redacted> Cc: Rajeev Kumar <redacted> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> Acked-by: Jamie Iles <redacted> Acked-by: Linus Walleij <redacted> Acked-by: Mark Brown <redacted> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Kukjin Kim <redacted> Acked-by: Olof Johansson <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de> However,
quoted hunk ↗ jump to hunk
index 6894df1..d5ee437 100644--- a/arch/arm/common/vic.c +++ b/arch/arm/common/vic.c@@ -83,6 +83,8 @@ static struct vic_device vic_devices[CONFIG_ARM_VIC_NR]; static int vic_id; +static void vic_handle_irq(struct pt_regs *regs); + /** * vic_init2 - common initialisation code * @base: Base of the VIC.@@ -466,7 +468,7 @@ static int handle_one_vic(struct vic_device *vic, struct pt_regs *regs) * Keep iterating over all registered VIC's until there are no pending * interrupts. */ -asmlinkage void __exception_irq_entry vic_handle_irq(struct pt_regs *regs) +static asmlinkage void __exception_irq_entry vic_handle_irq(struct pt_regs *regs) { int i, handled;
I'm a big fan of the "no forward function declarations in .c files" rule. Can I convince to reorder the file contents instead to avoid the forward declaration? Arnd