[PATCH] ARM: EXYNOS: enable 4 cores secondary cpu up for exynos5440
From: Olof Johansson <hidden>
Date: 2013-01-02 20:29:10
Also in:
linux-samsung-soc
Hi, On Mon, Dec 31, 2012 at 11:09 AM, Kukjin Kim [off-list ref] wrote:
quoted hunk ↗ jump to hunk
No need to check power on/off with pmu control to support hotplug in/out on exynos5440. And this patch enables 4 cores on exynos5440. Signed-off-by: Kukjin Kim <redacted> --- arch/arm/mach-exynos/platsmp.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-)diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index c5c840e..495a501 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c@@ -40,6 +40,8 @@ static inline void __iomem *cpu_boot_reg_base(void) { if (soc_is_exynos4210() && samsung_rev() == EXYNOS4210_REV_1_1) return S5P_INFORM5; + else if (soc_is_exynos5440()) + return (S5P_VA_CHIPID + 0x560); return S5P_VA_SYSRAM; }@@ -116,27 +118,30 @@ static int __cpuinit exynos_boot_secondary(unsigned int cpu, struct task_struct */ write_pen_release(phys_cpu); - if (!(__raw_readl(S5P_ARM_CORE1_STATUS) & S5P_CORE_LOCAL_PWR_EN)) { - __raw_writel(S5P_CORE_LOCAL_PWR_EN, - S5P_ARM_CORE1_CONFIGURATION); + if (!soc_is_exynos5440()) { + if (!(__raw_readl(S5P_ARM_CORE1_STATUS) & S5P_CORE_LOCAL_PWR_EN)) { + __raw_writel(S5P_CORE_LOCAL_PWR_EN, + S5P_ARM_CORE1_CONFIGURATION);
It seems better to create a helper function here instead and calling that, instead of switching to a conditional open-coded block to this function.
quoted hunk ↗ jump to hunk
@@ -178,6 +183,8 @@ static void __init exynos_smp_init_cpus(void) if (soc_is_exynos5250()) ncores = 2; + else if (soc_is_exynos5440()) + ncores = 4;
In the future it would make sense to get the core count from the device tree instead. -Olof