[PATCH Resend] ARM: pxa27x: fix ac97 controller warm reset code
From: Igor Grinberg <hidden>
Date: 2013-01-01 12:40:50
From: Igor Grinberg <hidden>
Date: 2013-01-01 12:40:50
On 12/31/12 23:04, Mike Dunn wrote:
On 12/31/2012 01:56 AM, Igor Grinberg wrote:quoted
On 12/28/12 23:06, Mike Dunn wrote:
[...]
quoted
How about one of the below: 1) GPIO113_GPIO | MFP_PULL_HIGH, GPIO95_GPIO | MFP_PULL_HIGH, or 2) introduce something like: GPIO113_AC97_nRESET_GPIO_HIGH GPIO95_AC97_nRESET_GPIO_HIGH in the mfp-pxa27x.h file and use them in the structure above.OK, will implement your suggestion and resubmit. To me, your first option seems clearer to the casual reader.
Actually, the second option is more robust, because you actually drive the pin. -- Regards, Igor.