[PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller

Hello.

On 03-01-2013 11:03, Heiko Schocher wrote:

quoted

quoted

add OF support for the davinci nand controller.

quoted

quoted

Signed-off-by: Heiko Schocher<redacted>
Cc: davinci-linux-open-source at linux.davincidsp.com
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree-discuss at lists.ozlabs.org
Cc: linux-mtd at lists.infradead.org
Cc: David Woodhouse<dwmw2@infradead.org>
Cc: Grant Likely<redacted>
Cc: Sekhar Nori<redacted>
Cc: Wolfgang Denk<redacted>
Cc: Scott Wood<redacted>

quoted

[...]

quoted

quoted

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index d94b03c..f386b3c 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c

[...]

quoted

@@ -518,9 +519,75 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
      },
  };

quoted

quoted

+#if defined(CONFIG_OF)
+static const struct of_device_id davinci_nand_of_match[] = {
+    {.compatible = "ti,davinci-nand", },
+    {},
+}

quoted

    I have only one question: have you ever try to compile this patch with
CONFIG_OF enabled? If you have, you would have noticed:

quoted

drivers/mtd/nand/davinci_nand.c:527: error: expected ?,? or ?;? before ?extern?

quoted

quoted

+MODULE_DEVICE_TABLE(of, davinci_nand_of_match);

Hmm.. maybe this crept in later after I sent the patches? They were
pending for a while ... I compiled it just yet again (based on my
tree when I posted this patch based on commit:

    I've just checked the archives: every patch version you posted had ';' 
after '}' missing.

WBR, Sergei