Thread (17 messages) 17 messages, 5 authors, 2013-01-03

[RFC 3/5] ARM: CTI: Convert CTI helpers to AMBA bus driver

From: Jon Hunter <hidden>
Date: 2013-01-02 19:13:47
Also in: linux-devicetree, linux-omap

On 12/21/2012 04:35 PM, Pratik Patel wrote:
On Fri, Dec 21, 2012 at 02:27:03PM -0800, Pratik Patel wrote:
quoted
On Wed, Dec 12, 2012 at 03:43:06PM -0600, Jon Hunter wrote:
quoted
+
+/**
+ * cti_irq_ack - acknowledges the CTI trigger output
+ * @cti: CTI instance
+ *
+ * Acknowledges the CTI trigger output by writting to the appropriate
+ * bit in the CTI interrupt acknowledge register.
+ */
+int cti_irq_ack(struct cti *cti)
+{
+	u32 v;
+
+	if (!cti || !cti->enabled)
+		return -EINVAL;
+
+	v = cti_readl(cti, CTIINTACK);
Just curious if CTIINTACK is a read-write register? This is a
read-only for us.
Mistyped - its a write-only for us
You are right. Looking at the ARM documentation this is a write-only
register. I had copied this function from the original helpers but had
not checked if this was readable. I will correct this.

Cheers
Jon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help