On 01/16/2013 10:03 PM, Hiroshi Doyu wrote:

Stephen Warren [off-list ref] wrote @ Wed, 16 Jan 2013 21:11:24 +0100:

quoted

quoted

quoted

+static int clk_frac_div_set_rate(struct clk_hw *hw, unsigned long rate,
+                               unsigned long parent_rate)
+{
+       struct tegra_clk_frac_div *divider = to_clk_frac_div(hw);
+       int div;
+       unsigned long flags = 0;

nit, is "flags" not needed to initialize here?

It avoids a compiler warning; the compiler doesn't that the if condition
that guards the path that uses flags is the same condition as the path
that initializes it. Or, it may be related to the fact that
spin_lock_irqsave() writes to the value through a pointer parameter, and
the compiler doesn't know it's an out-only parameter.

It might be better to append the special comment /* GCC */[1] on that line.

[1] https://lwn.net/Articles/529954/

I note that patch hasn't actually been merged though, so I think I'll
avoid doing that for now.