On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote:
From: Nicolas Ferre <redacted>
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
[]
quoted hunk ↗ jump to hunk
+static inline bool atmel_spi_use_dma(struct atmel_spi *as,
+ struct spi_transfer *xfer)
+{
+ if ((as->use_dma) && (xfer->len >= DMA_MIN_BYTES))
+ return true;
+ else
+ return false;
+}
Same unnecessary form.
return as->use_dma && xfer->len >= DMA_MIN_BYTES;
quoted hunk ↗ jump to hunk
+static inline bool atmel_spi_use_pdc(struct atmel_spi *as)
+{
+ if (as->use_pdc)
+ return true;
+ else
+ return false;
+}
Does this function really need to exist at all?