[PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL
From: Julia Lawall <hidden>
Date: 2013-01-02 09:44:39
Also in:
kernel-janitors, linux-media, lkml
On Wed, 2 Jan 2013, Russell King - ARM Linux wrote:
On Wed, Jan 02, 2013 at 08:10:36AM +0300, Dan Carpenter wrote:quoted
clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. I told Tony about this but everyone has been gone with end of year holidays so it hasn't been addressed. Tony, please fix it so people don't apply these patches until clk_get() is updated to not return NULL. It sucks to have to revert patches.How about people stop using IS_ERR_OR_NULL for stuff which it shouldn't be used for?
Perhaps the cases where clk_get returns NULL could have a comment indicating that NULL does not represent a failure? In 3.7.1, it looks like it might have been possible for NULL to be returned by clk_get in arch/mips/loongson1/common/clock.c, but that definition seems to be gone in a recent linux-next. The remaining definitions look OK. julia