[PATCH 3/4] iio: mxs: Implement support for touchscreen

Hi,

Dmitry Torokhov writes:

Hi Marek, Jonathan,

On Sat, Dec 08, 2012 at 10:13:44AM +0000, Jonathan Cameron wrote:

quoted

On 12/07/2012 03:24 PM, Marek Vasut wrote:

[...]

quoted

quoted

+	int			use_touchbutton:1;

Why would someone not want to use it?

quoted

quoted

+	int			use_touchscreen_4wire:1;
+	int			use_touchscreen_5wire:1;

bit fields should be of unsigned type, because otherwise the 'true'
value will be '-1' rather than '1'.


Lothar Wa?mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________