On 12/06/2012 01:25 AM, Joseph Lo wrote:

On Wed, 2012-12-05 at 18:50 +0800, Lorenzo Pieralisi wrote:

quoted

On Wed, Dec 05, 2012 at 10:01:49AM +0000, Joseph Lo wrote:

quoted

 static struct cpuidle_driver tegra_idle_driver = {
        .name = "tegra_idle",
        .owner = THIS_MODULE,
        .en_core_tk_irqen = 1,
+#ifdef CONFIG_PM_SLEEP
+       .state_count = 2,
+#else
        .state_count = 1,
+#endif

These hardcoded values are not nice.

OK. I will change it to runtime detection when idle driver registration.

Personally, I find doing this at compile-time much better; the
conditional definition of state_count is right next to the conditional
setup of the array whose size it defines. Assigning state_count at
run-time ense up moving the two pieces of logic apart, which seems
likely to cause more issues...

quoted

quoted

        .states = {
                [0] = ARM_CPUIDLE_WFI_STATE_PWR(600),
+#ifdef CONFIG_PM_SLEEP
+               [1] = {
+                       .enter                  = tegra20_idle_lp2,
+                       .exit_latency           = 5000,
+                       .target_residency       = 10000,
+                       .power_usage            = 0,
+                       .flags                  = CPUIDLE_FLAG_TIME_VALID,
+                       .name                   = "powered-down",
+                       .desc                   = "CPU power gated",
+               },
+#endif
        },
 };