Thread (58 messages) 58 messages, 6 authors, 2012-12-05
STALE4926d

[PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

From: Christoffer Dall <hidden>
Date: 2012-12-03 14:54:12
Also in: kvm

[...]
quoted
quoted
+
+                       clear_bit(c, &sources);
+               }
+
+               if (!sources)
+                       clear_bit(i, pending);
What does this signify and how does it happen? An SGI without a source
sounds pretty weird...
See the clear_bit() just above. Once all the sources for this SGI are
cleared, we can make the interrupt not pending anymore.
every time I read the code, I get completely bogged up on trying to
understand this case and I tell myself we should put a comment here,
then I understand why it happens and I think, oh it's obvious, no
comment needed, but now I (almost) forgot again. Could we add a
comment?

-Christoffer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help