On Tue, 11 Dec 2012, Sergei Shtylyov wrote:

Hello.

On 11-12-2012 14:58, Julia Lawall wrote:

quoted

From: Julia Lawall <redacted>

quoted

The function at91_dt_node_to_map is ultimately called by the function
pinctrl_get, which is an exported function.  Since it is possible that this
function is not called from within a probe function, for safety, the kfree
is converted to a devm_kfree, to both free the data and remove it from the
device in a failure situation.

quoted

A newline is added in the call to devm_kfree to avoid exceeding the 80

   devm_kzalloc() you mean?

Yes, sorry.  Should I send a new patch?

thanks,
julia

quoted

character limit.

quoted

Signed-off-by: Julia Lawall <redacted>

quoted

---
  drivers/pinctrl/pinctrl-at91.c |    5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index c5e7571..0da8a5f 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c

@@ -255,7 +255,8 @@ static int at91_dt_node_to_map(struct pinctrl_dev

*pctldev,
  	}

  	map_num += grp->npins;
-	new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num,
GFP_KERNEL);
+	new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num,
+			       GFP_KERNEL);

WBR, Sergei