Thread (1 message) 1 message, 1 author, 2012-11-14

[PATCHv2] ARM: OMAP4: USB: power down MUSB PHY during boot

From: Kevin Hilman <hidden>
Date: 2012-11-14 00:03:14
Also in: linux-omap

Felipe Balbi [off-list ref] writes:
HI,

On Fri, Nov 09, 2012 at 04:30:35PM +0200, Tero Kristo wrote:
quoted
Commit c9e4412ab8eb8ef82d645d8749c4ce96ad490007 removed all of the USB
PHY functions for OMAP4, but this causes a problem with core retention
as the MUSB module remains enabled if omap-usb2 phy driver is not used.
This keeps the USB DPLL enabled and prevents l3_init pwrdm from idling.

Fixed by adding a minimal function back that disables the USB PHY during
boot.

Signed-off-by: Tero Kristo <redacted>
Cc: Kishon Vijay Abraham I <redacted>
Cc: Felipe Balbi <redacted>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Kevin Hilman <redacted>
looks good to me. I would still suggest adding a REVISIT or FIXME note
stating that this should be moved to SCM driver eventually ;-)

Other than that:

Acked-by: Felipe Balbi <redacted>
Thanks will try to get this in for v3.8 along with the original patch
4/9 which gets full-chip retention working on OMAP4.

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help