On Thu, Nov 1, 2012 at 6:48 AM, Haojian Zhuang [off-list ref] wrote:

On Thu, Nov 1, 2012 at 1:47 AM, Tony Lindgren [off-list ref] wrote:

quoted

quoted

 static void pcs_pin_dbg_show(struct pinctrl_dev *pctldev,
                                      struct seq_file *s,
-                                     unsigned offset)
+                                     unsigned pin)
 {
      struct pcs_device *pcs;
-     unsigned val;
+     unsigned val, mux_bytes;

      pcs = pinctrl_dev_get_drvdata(pctldev);

-     val = pcs->read(pcs->base + offset);
-     val &= pcs->fmask;
+     mux_bytes = pcs->width / BITS_PER_BYTE;
+     val = pcs->read(pcs->base + pin * mux_bytes);

      seq_printf(s, "%08x %s " , val, DRIVER_NAME);
 }
--
1.7.10.4

There's also include a bug fix. I'm OK that this patch could be
included in -rc cycle.

A debug print can by definition not be a regression, it
should not have a specific use other than debugging.

And those debugging can use linux-next or separate
patches or whatever ... better keep this series together.

Yours,
Linus Walleij