Thread (4 messages) flat view 4 messages, 2 authors, 2012-11-01
STALE5050d REVIEWED: 2 (2M)

1 review trailer.

[PATCH] i2c: mxs: remove broken PIOQUEUE support

From: marex@denx.de (Marek Vasut)
Date: 2012-11-01 14:28:17
Also in: linux-i2c

Dear Wolfram Sang,
This I2C master can do DMA and PIOQUEUE (PIO with FIFO). Originally,
only PIOQEUE
PIOQUEUE ;-)
was supported, then DMA support was added. The original
intention was to keep PIOQUEUE since it has less overhead what is nice
for small transfers. However, runtime switching between PIOQEUE and DMA
depending on the transfer size never worked despite a lot of trying.
Since PIOQUEUE mode itself was flaky (polling at places where interrupts
failed to work) and the implementation also imposed a size limit for
transfers, it is best to remove the support altogether which makes the
driver a lot cleaner and more robust. If somebody really wants less
overhead, plain PIO mode could still be implemented with the addidtional
advantage that this mode is also available on MX23, too.
Yes, looks to be the way to go.

Reviewed-by: Marek Vasut <marex@denx.de>

Thanks

[...]

Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help