[PATCH v3 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock
From: Peter Chen <hidden>
Date: 2012-11-25 09:18:35
Also in:
linux-devicetree
On Fri, Nov 23, 2012 at 05:20:51PM +0100, Michael Grzeschik wrote:
quoted
usbphy: used to transfer data (like your per)The "per" clk is a different clk than the usbphy. We have an usbphy clk aswell on the mx5x. As discussed before [1], we need a solution to enable the usbphy clk. The current approach is to let the nop-xceiver enable this. [1] http://www.spinics.net/lists/linux-usb/msg74489.html
It does not matter which the name is, this clock is related to usb 480M or its source. We use nop-xceiver is just to create struct usb_otg and usb_phy. Clock information can be at imx specific file like cil13xxx_imx.
quoted
mx6q: - usboh3(Index 162 at DT), used to access register - usbphy(Index 182 for otg port at DT), at phy controllerquoted
So, we may consider a way to consolidate both mx6q (mx28) and mxc (mx5x, mx3x) platforms.Yes, we will discuss a real clktree solution in the usbmisc driver for the different cores. The first thoughts are, that the clk configuration has completely to be done inside the usbmisc driver. For this, the usbmisc needs to become a hard dependency for the ci13xxx_imx glue code.
For my mind, imx usb clock handling is better only at place, that is cil13xxx_imx. We can have imx_clk_enable and imx_clk_disable in it, and handling clk in imx_clk_enable using id_table or what else platform specific.
Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
-- Best Regards, Peter Chen