[PATCH 1/3] gpio: Add simple poweroff-gpio driver

On Mon, Nov 12, 2012 at 09:17:48AM -0700, Stephen Warren wrote:

On 11/12/2012 01:25 AM, Andrew Lunn wrote:

quoted

On Sun, Nov 11, 2012 at 03:03:49PM -0700, Stephen Warren wrote:

quoted

On 11/11/2012 09:21 AM, Andrew Lunn wrote:

quoted

From: Jamie Lentin <redacted>

Given appropriate devicetree bindings, this driver registers a
pm_power_off function to set a GPIO line high/low to power down
your board.

quoted

quoted

quoted

diff --git a/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt b/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt

quoted

+Required properties:
+- compatible : should be "gpio-poweroff".
+- gpios : The GPIO to set high/low, see "gpios property" in
+  Documentation/devicetree/bindings/gpio/gpio.txt. If the pin should be
+  low to power down the board set it to "Active Low", otherwise set
+  gpio to "Active High".

Unfortunately, not all GPIO bindings support active high/low flags in
the GPIO specifier. As such, the flags there are basically useless.
Other bindings (e.g. IIRC the fixed-regulator binding) have added a
separate active-high property to indicate the GPIO polarity. This
binding should probably follow suite.

Humm, so are you saying of_get_named_gpio_flags() is deprecated?

I don't know if it's deprecated, but it's certainly not useful in
generic code.

Hi Linus, Anton

How do you see this? 

I'm happy to implement an enable-active-high property, but it seems to
go against the purpose of of_get_named_gpio_flags(). Is that function
deprecated?

	Thanks
		Andrew