On Tue, Oct 30, 2012 at 3:12 PM, AnilKumar, Chimata [off-list ref] wrote:

I completely understood this named modes, I have added named
modes like this in am335x-xxx.dts files

I do not understand how the pinctrl-single dts files work actually,
so please get Tony to review this part.

I think "pinctrl-1" state will be used in driver
suspend/resume calls.

Hopefully, I think you should test the code and monitor the
system to make sure the right thing happens.

I have the pinmux/conf settings for default state but fully
optimized pinmux/conf values in idle & suspend states are not
available yet.

You have defined a "sleep" state which is what should be used
for suspend? Or do you mean that you do have a state but
you're just not defining it to the most optimal setting yet?

Even though if I add here, I am unable to test
these pins in suspend state because suspend/resume of AM35xx
is not added yet

Aha.

I have two options now
- add only default states for now, I can add reset of
the state details once suspend/resume is supported.
- add same values in all the states, modify those once
suspend/resume is added for AM335x.

The OMAP maintainer gets to choose how this is to be done,
it's none of my business :-)

Yours,
Linus Walleij