Thread (7 messages) flat view 7 messages, 4 authors, 2012-12-01

[RFC 1/2] clk: use struct clk only for external API

From: Rabin Vincent <hidden>
Date: 2012-11-28 21:26:56
Also in: lkml

2012/11/28 viresh kumar [off-list ref]:
On Wed, Nov 28, 2012 at 9:31 PM, viresh kumar [off-list ref] wrote:
quoted
On Wed, Nov 28, 2012 at 5:22 PM, Rabin Vincent
Isn't something wrong here? For common clk case shouldn't
this be:
quoted
+#define clk_to_clk_core(clk)  (&clk->clk)
+#define clk_core_to_clk(core) (container_of(clk, ...))  //not getting into the exact format here
Sorry, if i am missing basics.
Ok. I saw these getting updated in 2/2. But it means this individual patch
is broken and this is not allowed i believe.
It would be better to use container_of / &clk->clk, yes.  I wouldn't
really describe it as "broken" though since it works fine as it is,
since it's the first and only element.  I will change it anyway.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help