Thread (18 messages) 18 messages, 3 authors, 2012-11-29

[PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

From: Shawn Guo <hidden>
Date: 2012-11-28 14:32:17
Also in: linux-devicetree, linux-pm, lkml

On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote:
Standard practice is to have cpufreq_set_target() handle voltage
transitions and leave clk_set_rate() handle the frequency changes.
The standard practice is to have cpufreq_set_target() handle both
voltage and frequency transitions, while voltage is handled by regulator
and frequency by clk API.
I'd
have to move most of the logic of hb_set_target() into
clk_highbank.c:clk_pll_set_rate() and then add extra logic for when
cpufreq is not enabled/loaded.
You only need to move hb_voltage_change() into cpu clock's .set_rate()
hook with no need of checking if cpufreq is enabled or not.
I don't think the clk maintainers would
take that patch, either.
This is all handled platform clock specific .set_rate() hook.  I doubt
it will concern clk maintainers at all, especially when doing so we
will avoid another cpufreq driver by just using cpufreq-cpu0 driver.

Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help