Thread (11 messages) 11 messages, 5 authors, 2012-11-29

[PATCH v5 4/5] iommu/omap: adapt to runtime pm

From: Felipe Contreras <hidden>
Date: 2012-11-22 18:32:12
Also in: linux-iommu, linux-omap, lkml

On Tue, Nov 20, 2012 at 2:05 AM, Omar Ramirez Luna [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -1022,7 +1019,8 @@ static int __devexit omap_iommu_remove(struct platform_device *pdev)
        release_mem_region(res->start, resource_size(res));
        iounmap(obj->regbase);

-       clk_put(obj->clk);
+       pm_runtime_disable(obj->dev);
+
        dev_info(&pdev->dev, "%s removed\n", obj->name);
        kfree(obj);
        return 0;
I still believe this is not needed. The device framework does that
when removing the device, and does it more properly, with
__pm_runtime_disable(dev, false).

Cheers.

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help