[PATCH RFC] i2c: omap: Fix the revision register read
From: Felipe Balbi <hidden>
Date: 2012-10-31 11:52:54
Also in:
linux-i2c, linux-omap
From: Felipe Balbi <hidden>
Date: 2012-10-31 11:52:54
Also in:
linux-i2c, linux-omap
Hi, On Wed, Oct 31, 2012 at 04:28:38PM +0530, Shubhrajyoti wrote:
On Wednesday 31 October 2012 03:42 PM, Felipe Balbi wrote:quoted
quoted
quoted
+ if (!_dev->regs) + return 0;this is wrong, you need to make sure dev->regs is set early enough.to set the dev->regs I use the value read from revision register. to read the revision register I do a get_sync first. This in turn leads to the call to resume handler. At this point the regs is NULL and so the check. After reading the register and checking the scheme bit. the reg map is populated. How can this issue be solved?
aaa good point, missed that. Nevermind that comment ;-) cheers -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121031/cc7b16de/attachment.sig>