Thread (4 messages) 4 messages, 4 authors, 2012-11-08
STALE4953d

[PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG

From: Vivek Gautam <hidden>
Date: 2012-10-31 05:47:29
Also in: linux-samsung-soc

Hi all,

On Tue, Oct 9, 2012 at 2:04 PM, Jingoo Han [off-list ref] wrote:
On Friday, October 05, 2012 10:27 PM Vivek Gautam wrote
quoted
EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG
system register (base addr + 0x230). It's wrongly placed in regs-pmu.
Actual register at offset 0x230 in PMU is SEQ_TRANSITION4.

Signed-off-by: Vivek Gautam <redacted>
As you mentioned, this definition is wrong.
So, it should be removed.

Reviewed-by: Jingoo Han <redacted>

quoted
---
 arch/arm/mach-exynos/include/mach/regs-pmu.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
index d4e392b..70b2795 100644
--- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
+++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
@@ -230,8 +230,6 @@

 /* For EXYNOS5 */

-#define EXYNOS5_USB_CFG                                              S5P_PMUREG(0x0230)
-
Any thoughts about this please.
quoted
 #define EXYNOS5_AUTO_WDTRESET_DISABLE                                S5P_PMUREG(0x0408)
 #define EXYNOS5_MASK_WDTRESET_REQUEST                                S5P_PMUREG(0x040C)

--
1.7.6.5



-- 
Thanks & Regards
Vivek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help