[PATCH] i2c: omap: ensure writes to dev->buf_len are ordered
From: paul@pwsan.com (Paul Walmsley)
Date: 2012-10-27 15:59:29
Also in:
linux-i2c, linux-omap
From: paul@pwsan.com (Paul Walmsley)
Date: 2012-10-27 15:59:29
Also in:
linux-i2c, linux-omap
On Sat, 27 Oct 2012, Santosh Shilimkar wrote:
Another alternative, which I will recommend to just make use of the read*/wrire* instead __raw versions. The barriers are taken care already and driver point of view, it is transparent.
Those barriers will disappear if CONFIG_ARM_DMA_MEM_BUFFERABLE is set to N, so that's probably not the right thing to do in this case. The barrier here isn't DMA-related, it's needed due to the design of the driver. In fact the wmb() is probably overkill, since only a compiler reordering barrier is needed. It can probably just be barrier(). - Paul