Thread (8 messages) 8 messages, 3 authors, 2012-10-29
STALE4994d

[PATCH] ARM: OMAP1: usb: fix sparse warnings

From: tony@atomide.com (Tony Lindgren)
Date: 2012-10-26 21:28:41
Also in: linux-omap

* Paul Walmsley [off-list ref] [121026 14:27]:
On Fri, 26 Oct 2012, Tony Lindgren wrote:
quoted
* Paul Walmsley [off-list ref] [121026 13:54]:
quoted
Resolve the following sparse warnings:

arch/arm/mach-omap1/usb.c:304:12: warning: symbol 'omap1_usb0_init' was not declared. Should it be static?
arch/arm/mach-omap1/usb.c:412:12: warning: symbol 'omap1_usb1_init' was not declared. Should it be static?
arch/arm/mach-omap1/usb.c:478:12: warning: symbol 'omap1_usb2_init' was not declared. Should it be static?

by declaring those functions as static.  Also remove the unneeded
prototypes and related code from the plat/usb.h header file.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <redacted>
---

Tony, care to take this one?
Let's apply just the usb.c changes on omap-for-v3.8/cleanup-headers
as plat/usb.h is now gone?
OK no problem, thought you might want it for the -rc series...
Looks like it's not urgent for the -rc series, so let's not
introduce more self-inflicted merge conflicts. If that's OK
with you, I can apply it to omap-for-v3.8/cleanup-headers
without the header changes.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help