On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi [off-list ref] wrote:

Hi,

On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote:

quoted

quoted

quoted

@@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev)
 {
      struct omap_i2c_dev *_dev = dev_get_drvdata(dev);

-     if (_dev->flags & OMAP_I2C_FLAG_RESET_REGS_POSTIDLE) {
-             omap_i2c_write_reg(_dev, OMAP_I2C_CON_REG, 0);
-             omap_i2c_write_reg(_dev, OMAP_I2C_PSC_REG, _dev->pscstate);
-             omap_i2c_write_reg(_dev, OMAP_I2C_SCLL_REG, _dev->scllstate);
-             omap_i2c_write_reg(_dev, OMAP_I2C_SCLH_REG, _dev->sclhstate);
-             omap_i2c_write_reg(_dev, OMAP_I2C_BUF_REG, _dev->bufstate);
-             omap_i2c_write_reg(_dev, OMAP_I2C_SYSC_REG, _dev->syscstate);
-             omap_i2c_write_reg(_dev, OMAP_I2C_WE_REG, _dev->westate);
-             omap_i2c_write_reg(_dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN);
-     }
-
-     /*
-      * Don't write to this register if the IE state is 0 as it can
-      * cause deadlock.
-      */
-     if (_dev->iestate)
-             omap_i2c_write_reg(_dev, OMAP_I2C_IE_REG, _dev->iestate);

this part is not on __omap_i2c_init() so you're potentially causing a
regression here.

iestate is set at init so cannot be zero. so the check was removed.

so you never read it back ? Then you need to add a note for that in
changelog, since this is a behavior change ;-)

Indeed will do.

--
balbi