Thread (8 messages) 8 messages, 5 authors, 2012-10-15
STALE5005d

[PATCH v2] i2c: change the id to let the i2c-gpio work

From: Nicolas Ferre <hidden>
Date: 2012-10-15 08:12:43
Also in: linux-i2c

On 10/15/2012 04:09 AM, Bo Shen :
Hi Joachim Eastwood,

On 10/13/2012 1:42, Joachim Eastwood wrote:
quoted
Hi Bo Shen,

On Fri, Oct 12, 2012 at 11:42 AM, Bo Shen [off-list ref] wrote:
quoted
The i2c-gpio driver will turn the platform device ID to busnum.
When using platfrom device ID as -1, it means dynamically assigned
the busnum. When writing code, we need to make sure the busnum,
and call i2c_register_board_info(int busnum, ...) to register device
if using -1, we do not know the value of busnum.

In order to solve this issue, set the platform device ID as a fix number
Here using 0 to match the busnum used in i2c_regsiter_board_info().
I have been bitten by this myself on RM9200.
quoted
Signed-off-by: Bo Shen <redacted>
---
Change since v1
   Make the commit message more clear
---
  arch/arm/mach-at91/at91sam9260_devices.c |    2 +-
This pattern exist in at91rm9200_devices.c, at91sam9261_devices.c,
at91sam9263_devices.c and at91sam9rl_devices.c you might want to fix
them as well.
Thanks for your information.
After I test these boards, I will send patches to fix them, while not in
this patch.
I am in favor of doing a comprehensive patch series that covers all
aspects of this issue:
- each boards
- both i2c-gpio and i2c-at91 cases

Bye,
-- 
Nicolas Ferre
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help