Thread (12 messages) flat view 12 messages, 3 authors, 2012-10-12
STALE5079d

[PATCH] i2c: change the id to let the i2c device work

From: Bo Shen <hidden>
Date: 2012-10-12 04:57:34
Also in: linux-i2c

Hi Mark,

On 10/12/2012 12:40, Mark Brown wrote:
On Fri, Oct 12, 2012 at 10:34:18AM +0800, Bo Shen wrote:
quoted
As the old method will use platform device id, change the id to
let the i2c device work
What are "the old method" and new method?  You're not explaining why
this is needed...
Maybe use the 'legacy method' will be better (I am not sure). Now, the 
Linux kernel is transferring to device tree which doesn't use platform 
device id. So, change the id to let the legacy code work.

May you understand.
quoted
  static struct platform_device at91sam9260_twi_device = {
  	.name			= "i2c-gpio",
-	.id			= -1,
+	.id			= 0,
  	.dev.platform_data	= &pdata,
This looks like a regression, if there's only one of a given type of
device in the system it should have no numeric ID in the display name so
having -1 is appropriate.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help