[PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion
From: Russell King - ARM Linux <hidden>
Date: 2012-10-09 13:40:31
Also in:
linux-media
On Mon, Oct 08, 2012 at 07:37:03PM -0300, Fabio Estevam wrote:
quoted hunk ↗ jump to hunk
@@ -460,7 +462,11 @@ static int mx2_camera_add_device(struct soc_camera_device *icd) if (pcdev->icd) return -EBUSY; - ret = clk_prepare_enable(pcdev->clk_csi); + ret = clk_prepare_enable(pcdev->clk_csi_ahb); + if (ret < 0) + return ret; + + ret = clk_prepare_enable(pcdev->clk_csi_per); if (ret < 0) return ret;
From the point of view of error cleanup, this looks buggy to me. If
the prepare_enable for the per clock fails, what cleans up the ahb clock?