Thread (1 message) 1 message, 1 author, 2012-10-02

[PATCH v6 3/5] watchdog: at91sam9_wdt: add device tree support

From: andrew@lunn.ch (Andrew Lunn)
Date: 2012-10-02 19:59:14
Also in: linux-devicetree, linux-watchdog

I was thinking to add a more generic helper function like this:

static inline void watchdog_get_dttimeout(struct device_node *node,
u32 *timeout)
{
	if (node)
		of_property_read_u32(node, "timeout", &wdd->timeout);
}
You forgot to change the function signature. 

Also, if you are adding a generic function, it should be a generic
function for the framework. All drivers should be slowly moving
towards the framework, so adding functions which help you not move
towards the framework are wrong.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help