[PATCH v3 02/11] clk: davinci - add PSC clock driver

On 10/28/2012 03:24 PM, Linus Walleij wrote:

On Thu, Oct 25, 2012 at 6:11 PM, Murali Karicheri [off-list ref] wrote:

quoted

This is the driver for the Power Sleep Controller (PSC) hardware
found on DM SoCs as well Keystone SoCs (c6x). This driver borrowed
code from arch/arm/mach-davinci/psc.c and implemented the driver
as per common clock provider API. The PSC module is responsible for
enabling/disabling the Power Domain and Clock domain for different IPs
present in the SoC. The driver is configured through the clock data
passed to the driver through struct clk_psc_data.

Signed-off-by: Murali Karicheri <redacted>

Acked-by: Linus Walleij <redacted>

Here is some pedantic stuff if you're really bored:

quoted

diff --git a/drivers/clk/davinci/clk-psc.c b/drivers/clk/davinci/clk-psc.c

(...)

quoted

+               ptcmd = 1 << domain;

ptcmd = BIT(domain);

quoted

+               pdctl = readl(psc_base + PDCTL + 4 * domain);
+               pdctl |= 0x100;

pdctl |= BIT(8); /* and here a comment explaing what on earth that means */

quoted

+       } else {
+               ptcmd = 1 << domain;

ptcmd = BIT(domain);

Yours,
Linus Walleij

Linus,

Thanks. I will fix the above and add your Acked-by in the next revision 
of the patch.

Murali