Thread (17 messages) flat view 17 messages, 5 authors, 2012-10-24

[PATCH 2/2] arm: mvebu: Add hardware I/O Coherency support

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-10-24 20:30:26
Also in: lkml

On Wednesday 24 October 2012, Gregory CLEMENT wrote:
quoted
No, I was thinking of making the underlying functions globally visible
and have extern declarations in a header file so you can access them
directly.

Generally speaking, when you run into a problem with common code, your
first approach should be to fix the common code before you try to work
around it.
OK I thought it was done on purpose. But if you consider it needs to be
fixed I will add patch for it in next version.
As long as the functions were only used locally in one file, it's
better not to make them globally visible as a rule. But if we know
that they are needed, that should be made explicit. Please fix this
by submitting another patch to make those functions global and then
rebase this series on top of that.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help