Thread (2 messages) flat view 2 messages, 2 authors, 2012-10-10

[PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open

From: Oliver Neukum <hidden>
Date: 2012-10-10 12:37:24
Also in: lkml

On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote:
From: Constantine Shulyupin <redacted>

Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.

Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.

--
Changelog:
-- Fixed accordinly feedback of Oliver Neukum oneukum at suse.de: also need to drop the lock.
Well, touching file->private_data is not nice. It is correct, but
really dirty. The skeleton driver should be nice. Could you introduce
a second label for goto at the right place?

	Regards
		Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help