Thread (40 messages) 40 messages, 13 authors, 2012-10-31

[PATCH 02/16] ARM: binfmt_flat: unused variable 'persistent'

From: Greg Ungerer <hidden>
Date: 2012-10-08 05:47:05
Also in: lkml

On 06/10/12 00:55, Arnd Bergmann wrote:
The flat_get_addr_from_rp() macro does not use the 'persistent' argument
on ARM, causing a harmless compiler warning. A cast to void removes
that warning.

Without this patch, building at91x40_defconfig results in:

fs/binfmt_flat.c: In function 'load_flat_file':
fs/binfmt_flat.c:746:17: warning: unused variable 'persistent' [-Wunused-variable]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Ungerer <redacted>
Cc: Russell King <redacted>
Cc: Bryan Wu <redacted>
Acked-by: Greg Ungerer <redacted>

I can pick this one up to, and push to the arm-soc tree.

Regards
Greg

quoted hunk ↗ jump to hunk
---
  arch/arm/include/asm/flat.h |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/flat.h b/arch/arm/include/asm/flat.h
index 59426a4..e847d23 100644
--- a/arch/arm/include/asm/flat.h
+++ b/arch/arm/include/asm/flat.h
@@ -8,7 +8,7 @@
  #define	flat_argvp_envp_on_stack()		1
  #define	flat_old_ram_flag(flags)		(flags)
  #define	flat_reloc_valid(reloc, size)		((reloc) <= (size))
-#define	flat_get_addr_from_rp(rp, relval, flags, persistent) get_unaligned(rp)
+#define	flat_get_addr_from_rp(rp, relval, flags, persistent) ((void)persistent,get_unaligned(rp))
  #define	flat_put_addr_at_rp(rp, val, relval)	put_unaligned(val,rp)
  #define	flat_get_relocate_addr(rel)		(rel)
  #define	flat_set_persistent(relval, p)		0

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help