[PATCH v6 0/3] Updated Cortex-M3 series
From: Will Deacon <hidden>
Date: 2012-09-26 18:03:49
Hi Uwe, On Tue, Sep 25, 2012 at 04:00:26PM +0100, Uwe Kleine-K?nig wrote:
On Tue, Sep 25, 2012 at 03:47:26PM +0100, Jonathan Austin wrote:quoted
Looking at the patch series at a very superficial level, I wonder why you've chosen not to include any Kconfig/NVIC support at this stage, especially as you've posted some before and there appears to be something (presumably) working in your efm32 branch... It would be a shame to spend time on merging the basic support if there are issues that mean the interrupt support won't follow.I plan to expand common/gic.c for interrupt support. Currently I don't do much though because getting feedback and the changes into mainline is quite hard and I don't want to spend time now and hear later that I did it wrong or something. So I put my efforts on hold and only ping from time to time. :-(
My personal view is that merging the code without support for interrupts is fairly pointless, so the nvic code should certainly be included. I wouldn't worry too much about merging it with gic.c initially. That can come later, especially as we'll need to prise the gic into drivers/ at some point (it should be shared with arm64). I think one reason for the lack of feedback is the inability for people to run this code themselves. I believe Jonny was trying to get started with an FPGA / simulation, but some hardware would be great if there's any available... Cheers, Will