Thread (18 messages) 18 messages, 4 authors, 2012-12-25
STALE4918d

[PATCH 1/3] mmc: sdhci: rename platform_8bit_width to platform_bus_width

From: jh80.chung@samsung.com (Jaehoon Chung)
Date: 2012-09-25 07:28:17
Also in: linux-mmc

On 09/25/2012 03:15 PM, Sascha Hauer wrote:
On Tue, Sep 25, 2012 at 11:35:14AM +0900, Jaehoon Chung wrote:
quoted
On 09/24/2012 04:22 PM, Sascha Hauer wrote:
quoted
 	/*
 	 * If your platform has 8-bit width support but is not a v3 controller,
 	 * or if it requires special setup code, you should implement that in
-	 * platform_8bit_width().
+	 * platform_bus_width().
 	 */
-	if (host->ops->platform_8bit_width)
-		host->ops->platform_8bit_width(host, ios->bus_width);
-	else {
+	if (host->ops->platform_bus_width) {
+		host->ops->platform_bus_width(host, ios->bus_width);
+	} else {
Why add the brackets?
Took the chance to cleanup the codingstyle when changing these lines
anyway.
Anyway, this patch is reasonable. Looks good to me.

Best Regards,
Jaehoon Chung
Sascha
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help