Thread (16 messages) flat view 16 messages, 6 authors, 2012-09-13
STALE5072d

[PATCH] ARM: smp_twd: reprogram twd based on clk notifier

From: Linus Walleij <hidden>
Date: 2012-09-12 16:05:22

On Fri, Sep 7, 2012 at 10:19 AM, Shawn Guo [off-list ref] wrote:
-static struct notifier_block twd_cpufreq_nb = {
-       .notifier_call = twd_cpufreq_transition,
+static struct notifier_block twd_clk_nb = {
+       .notifier_call = twd_rate_change,
But what happens if there is a platform which is now using this through
cpufreq and has not yet switched to the common clock? It regresses
right, because no notifications arrive anymore? Does it even compile?

These in linux-next look like they could be in trouble:

cd arch/arm
grep -r smp_twd .
./arch/arm/mach-imx/clk-imx6q.c:	clk_register_clkdev(clk[twd], NULL, "smp_twd");
./arch/arm/mach-tegra/tegra30_clocks_data.c:	CLK_DUPLICATE("twd",
"smp_twd", NULL),

Tegra seems to be a common clk implementation, but imx6 looks like
it's in trouble right?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help