[PATCH 05/11] clk: Versatile Express clock generators ("osc") driver

On Tue, Sep 11, 2012 at 6:10 PM, Pawel Moll [off-list ref] wrote:

On Mon, 2012-09-10 at 20:14 +0100, Mike Turquette wrote:

(...)

quoted

quoted

+       osc = kzalloc(sizeof(*osc), GFP_KERNEL);

(...)

quoted

Minor nitpick: the error label tries to free osc, which in this case
shouldn't be freed because it is NULL.

quoted

+       kfree(osc);

(...)

$ grep kfree scripts/checkpatch.pl

(...)

$ grep -B2 kfree Documentation/CodingStyle

Can't you just use devm_kzalloc(&vecdev->dev, ...) and be done with it?

Yours,
Linus Walleij