[PATCH v2] ARM: initial multiplatform support

On 09/04/2012 01:56 AM, Arnd Bergmann wrote:

On Monday 03 September 2012, Rob Herring wrote:

quoted

On 09/03/2012 11:34 AM, Arnd Bergmann wrote:

quoted

quoted

@@ -254,27 +254,9 @@ config MMU
 #
 choice
        prompt "ARM system type"
+       depends on !ARCH_MULTIPLATFORM
        default ARCH_VERSATILE

Why did you move ARCH_MULTIPLATFORM out of the "choice" statement?
If we leave it in there, and make it the default, then we don't
even have to change the defconfigs any more (except the versatile
one, which is no longer the default), which I think is quite clever
and helps git-bisecting across this commit.

We don't have to change and of the defconfigs or .config in this patch.

How does ARCH_MULTIPLATFORM get set then when building the existing
defconfig files for the converted platforms?

Ahhh, right. Those need to be updated. It doesn't really matter if
ARCH_MULTIPLATFORM is in the choice or not. It matters if we move
platforms out of the choice or not. More on that below.

quoted

quoted

For instance, we could enable one platform to be used in
multiplatform kernels with the subset of its board files and
device drivers that are possible, while leaving board files
that cannot work with sparse-irq and drivers that rely on
platform specific headers as "depends on !ARCH_MULTIPLATFORM".

Individual platforms can still do that. I just happened to convert all
platforms which have no need to be in both. While you can do that, I
don't think we should encourage it. I don't think we want to see
platforms partially converted to common clk or sparse irq. The latter is
certainly not hard to do.

I was thinking of other cases actually:

* device drivers that we don't really care about much but that rely
  on a mach/* header file. In some cases it can be hard to clean up
  those headers, so as an intermediate step, we can just disable the
  drivers when building multiplatform.

depends on !ARCH_MULTIPLATFORM ?

* At least the Samsung platforms have files that are built for separate
  platforms in a way that does not work across platforms: 
  arch/arm/plat-samsung/devs.c depends heavily on constants defined
  in mach/*.h header files. When building for DT-only, we can decide to
  just not build this file.

I still think that should be possible on a per platform basis, but why
mandate that all platforms do that?

We have ARCH_FOO in the choice today. Assuming we want to keep the
choice name as is to not break configs (as Russell wanted), we have to
leave this alone. So then we create ARCH_FOO_MULTI for the mult-platform
case and also ARCH_FOO_OPTIONS to avoid duplicating all the per mach
selects for ARCH_FOO and ARCH_FOO_MULTI. However, then we have ARCH_FOO
as a depends all over the tree. I'd like to avoid having to fix-up all
those to be depends on ARCH_FOO_OPTIONS or (ARCH_FOO || ARCH_FOO_MULTI).

Rob