Thread (2 messages) 2 messages, 2 authors, 2012-09-21
STALE5050d

[PATCH] msm: clock: fix return value check in msm_clock_init()

From: Wei Yongjun <hidden>
Date: 2012-09-21 06:23:13
Also in: linux-arm-msm
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

From: Wei Yongjun <redacted>

In case of error, the function clk_get() returns ERR_PTR() not
NULL pointer. The NULL test in return value check should be
replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
---
 arch/arm/mach-msm/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-msm/clock.c b/arch/arm/mach-msm/clock.c
index d9145df..fd52891 100644
--- a/arch/arm/mach-msm/clock.c
+++ b/arch/arm/mach-msm/clock.c
@@ -148,7 +148,7 @@ void __init msm_clock_init(struct clk_lookup *clock_tbl, unsigned num_clocks)
 	mutex_unlock(&clocks_mutex);
 
 	ebi1_clk = clk_get(NULL, "ebi1_clk");
-	BUG_ON(ebi1_clk == NULL);
+	BUG_ON(IS_ERR(ebi1_clk));
 
 }
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help