Thread (12 messages) flat view 12 messages, 7 authors, 2012-09-19

[PATCH V6 1/2] of: Add generic device tree DMA helpers

From: Rob Herring <hidden>
Date: 2012-09-19 14:36:36
Also in: linux-devicetree, linux-omap

On 09/19/2012 09:24 AM, Arnd Bergmann wrote:
On Wednesday 19 September 2012, Matt Porter wrote:
quoted
quoted
+Optional properties:
+- #dma-channels:     Number of DMA channels supported by the controller.
+- #dma-requests:     Number of DMA requests signals supported by the
+                     controller.
Shouldn't these two optional properties drop the prefix #?  By
convention adopted from the various original OF/ePAPR/etc specs, the
only properties I would expect to see with this prefix are the
"*-cells" cell sizes. A quick search indicates this is the case
throughout all the current bindings.
I always assumed that the # prefix is used to indicate that we are counting
things instead of listing them.
Lots of properties count things, but don't have a #. nr_gpios or spi
chipselect counts for example. I'd say drop the #.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help