* Marek Vasut [off-list ref] [120904 20:13]:
Dear Bryan Wu,
quoted
On Sat, Sep 1, 2012 at 4:16 PM, AnilKumar Ch [off-list ref] wrote:
quoted
Adopt pinctrl support to leds-gpio driver based on leds-gpio
device pointer, pinctrl driver configure SoC pins to GPIO
mode according to definitions provided in .dts file.
Thanks for this, actually Marek Vasut submitted a similar patch
before. I'm pretty fine with this patch.
Thanks for submitting this actually ... I didn't have time to properly
investigate this.
quoted
But without proper DT setting, it will also give us warning I think.
or we can provide some dummy functions as a temp solution as Shawn
pointed out before.
But this driver is also used on hardware that's not yet coverted to DT, so I'd
say dev_warn() if CONFIG_OF is enabled and otherwise simply go on ? Actually,
can we not skip whole this pinctrl thing if CONFIG_OF is disabled? Actually (2),
what's the relationship between OF and pinctrl?
The warning should be pinctrl related as the pinctrl drivers may not be
device tree based drivers.
Regards,
Tony