[PATCH 5/5] of: Modify c_can binding documentation
From: AnilKumar, Chimata <hidden>
Date: 2012-09-03 04:35:39
Also in:
linux-devicetree, linux-omap
Hi Stephen, Thanks for the review, On Sun, Sep 02, 2012 at 07:32:38, Stephen Warren wrote:
On 09/01/2012 12:05 AM, AnilKumar, Chimata wrote:quoted
On Fri, Aug 31, 2012 at 14:59:21, AnilKumar, Chimata wrote:quoted
Modify c_can binding documentation according to recent review comments on device tree data addition patches.quoted
quoted
diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt index a43f083..90a70be 100644 --- a/Documentation/devicetree/bindings/net/can/c_can.txt +++ b/Documentation/devicetree/bindings/net/can/c_can.txt@@ -8,6 +8,8 @@ Required properties: registers map - interrupts : property with a value describing the interrupt number +- status : describes the node status either "disabled" or + "okay"That's a standrd property that applies to any node, and doesn't describe data required by the device itself (as do regs/interrupts) by simply whether the node is activated; I'm not sure it's worth mentioning it in a device-specific binding. A similar comment exists for the pre-existing description of interrupt-parent below.quoted
quoted
Optional properties: - interrupt-parent : The parent interrupt controller
Then, I will remove these properties from the doc. Thanks AnilKumar