[PATCH 2/2] PCI: Provide a default pcibios_update_irq()

On Sat, Sep 15, 2012 at 04:23:33PM -0600, Bjorn Helgaas wrote:

On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding
[off-list ref] wrote:

quoted

On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:

quoted

On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
[off-list ref] wrote:

quoted

--- a/drivers/pci/setup-irq.c
+++ b/drivers/pci/setup-irq.c

@@ -17,6 +17,14 @@
 #include <linux/ioport.h>
 #include <linux/cache.h>

+void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
+{
+#ifdef CONFIG_PCI_DEBUG
+       printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
+              pci_name(dev));

pr_debug()?
Or even better, dev_dbg()?

The problem with pr_debug() and dev_dbg() is that they will be compiled
out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG
is configured and make this dev_dbg()?

Sorry, fat-fingered the previous empty response.

We already have this in drivers/pci/Makefile:

    ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG

so dev_dbg() should be perfect.

Yeah, this occurred to me as well and I was just about to look it up
when I read your response. I'll make it dev_dbg() then.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120916/4e0ee8a5/attachment.sig>