Thread (8 messages) flat view 8 messages, 3 authors, 2012-09-10

[PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work

From: Prabhakar Lad <hidden>
Date: 2012-09-10 12:06:26
Also in: lkml

Hi Sekhar,

On Monday 10 September 2012 02:57 PM, Sekhar Nori wrote:
Hi Prabhakar,

On 9/7/2012 11:04 PM, Prabhakar Lad wrote:
quoted
On Fri, Sep 7, 2012 at 10:48 PM, Sekhar Nori [off-list ref] wrote:
quoted
quoted
quoted
+static struct vpif_subdev_info da850_vpif_capture_sdev_info[] = {
+#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT)
You agreed to get rid of these multiple ifdefs but you have not fixed that.
I have merged the top one, at later stage when we go  ahead and add sensor
support then we would have require to have define two
da850_vpif_capture_sdev_info
so to avoid it I have kept this one.
Lets get to that when we actually add sensor support. It might make
sense then. Right now, there is no reason to have them.
Ok I'll fix it for v3.

Regards,
--Prabhakar
Thanks,
Sekhar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help