Thread (2 messages) flat view 2 messages, 2 authors, 2012-08-31
STALE5107d REVIEWED: 1 (0M)

1 review trailer.

[PATCH v2 2/2] tty: serial: imx: don't reinit clock in imx_setup_ufcr()

From: Shawn Guo <hidden>
Date: 2012-08-31 02:14:24
Also in: linux-serial

On Fri, Aug 31, 2012 at 10:02:47AM +0200, Dirk Behme wrote:
Remove the clock configuration from imx_setup_ufcr(). This
isn't needed here and will cause garbage output if done.

To be be sure that we only touch the bits we want (TXTL and RXTL)
we have to mask out all other bits of the UFCR register. Add
one non-existing bit macro for this, too (bit 6, DCEDTE on i.MX6).

Signed-off-by: Dirk Behme <redacted>
CC: Shawn Guo <redacted>
CC: Sascha Hauer <s.hauer@pengutronix.de>
CC: Troy Kisky <redacted>
CC: Xinyu Chen <redacted>
CC: <redacted>
Acked-by: Shawn Guo <redacted>
---
Changes in v2: Instead of disabling imx_setup_ufcr() with an
ifndef CONFIG_SERIAL_CORE_CONSOLE, remove the unneeded clock 
configuration from imx_setup_ufcr() itself as proposed by Troy Kisky.

Note: If this patch is accepted, it should go to the same stable
kernels as patch #1 of this series. So most probably 3.4 and 3.5.
In such cases, you should repost the series instead of this patch only,
so that maintainer can apply them a little easier.  Let's see if
Greg is fine to apply patch #1 from the early post and #2 from here.

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help