[PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote:

On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote:

quoted

quoted

quoted

arch/arm/boot/dts/db8500.dtsi

quoted

quoted

I'm not actually seeing anything terribly problematic here, though the
regulator-name properties should really be removed as they're fairly
useless and seem to be missing the point of having the property.

quoted

Just looking at this now. 

quoted

The regulator-name property is used to populate constrains->name. Are
you sure you still want them all removed?

Yes, of course.  There's no way that a generic .dtsi used for any
possible board could come up with a sensible value.

So how should constrains->name be populated then? Would you prefer
regulator-names moved to the .dts file(s), or something else?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog